SNOW-799408: Close temp file handle before removing temp cache file #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1582 +/- ##
==========================================
- Coverage 82.51% 82.29% -0.23%
==========================================
Files 62 62
Lines 8815 8815
Branches 1305 1305
==========================================
- Hits 7274 7254 -20
- Misses 1206 1219 +13
- Partials 335 342 +7
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sfc-gh-aling
force-pushed
the
SNOW-799408-connector-not-handling-ocsp-response-validation-cache-file-correctly-in-windows
branch
from
05f4199 to
eed93b1
Compare
sfc-gh-stan
reviewed
Jun 2, 2023
sfc-gh-stan
reviewed
Jun 2, 2023
sfc-gh-mkeller
requested changes
Jun 5, 2023
sfc-gh-aling
deleted the
SNOW-799408-connector-not-handling-ocsp-response-validation-cache-file-correctly-in-windows
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-799408
temp file is already an open file handle, instead of opening it again, we directly write the bytes into the file handle and then close the fd
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.